fix(vtex): give the birthday matcher its own icon - #1651
Open
guitavano wants to merge 1 commit into
Open
Conversation
Contributor
Tagging OptionsShould a new tag be published when this PR is merged?
|
Contributor
📝 WalkthroughWalkthroughThe PR changes the birthday matcher icon metadata and replaces the user segment matcher’s discriminated-union props with a unified exported interface whose optional ChangesBirthday matcher icon
User segment Props contract
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
Change `@icon calendar-event` → `@icon gift`. It previously shared the calendar icon with the generic Date matcher; a gift gives the birthday matcher its own identity in the admin's matcher picker. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
guitavano
force-pushed
the
guitavano/vtex-matcher-forms
branch
from
July 30, 2026 15:13
9481570 to
f16cba2
Compare
guitavano
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Changes the birthday matcher's
@iconfromcalendar-event→gift. It previously shared the calendar icon with the generic Date matcher; a gift gives the birthday matcher its own identity in the admin's matcher picker.Note
An earlier revision of this PR also flattened
userSegment's unionPropsinto an enum, to work around the admin not rendering discriminated unions. That's been reverted — the admin (Studio) is being fixed to render unionPropsas a branch selector (with the interface@titles as labels, like the legacy admin did), souserSegmentkeeps its nicer union-of-interfaces source. Onlybirthday.tschanges here now.🤖 Generated with Claude Code